======================================================================== http://mondrian.corp.google.com/file/8654410///depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc?a=1 File //depot/googleclient/gears/opensource/gears/geolocation/network_location_request.cc (snapshot 1) ------------------------------------ Line 84: return NULL; assert? ------------------------------------ Line 87: delete request; Use a scoped_ptr for request? ------------------------------------ Line 297: is_processing_response_mutex_.Lock(); It's not clear to me why we need to hold this mutex before setting the is_shutdown_ flag. When we check this flag we don't lock any mutex. ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/8654410
