Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 8685030
or point your web browser to
http://mondrian/8685030
to review the following code:
Change 8685030 by [EMAIL PROTECTED] on 2008/10/22 12:35:33 *pending*
Introduce unregisterDropTarget, so that web apps can remove their
interest in drag and drop events on a DOM element.
This introduces a new JS-visible class, called
GearsDropTargetRegistration, which is a result of a
desktop.registerDropTarget call. It is safe for the web app to
ignore the return value from registerDropTarget.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=276 (212 added, 20 deleted, 44 changed)
OCL=8685030
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#193 edit
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#54 edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.cc#6
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_registry.h#4
edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc#5 edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.h#2 edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#3 edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.h#2 edit
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc#1
add
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h#1
add
...
//depot/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html#1
edit
276 delta lines: 212 added, 20 deleted, 44 changed
Also consider running:
g4 lint -c 8685030
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
