Hello andreip, zork, baran,
I'd like you to do a code review. Please execute
g4 diff -c 8719937
or point your web browser to
http://mondrian/8719937
to review the following code:
Change 8719937 by [EMAIL PROTECTED] on 2008/10/24 11:42:45 *pending*
Fixes build bustage due to bug in parse_stab.py.
R=andreip,zork,baran
[EMAIL PROTECTED]
DELTA=6 (0 added, 0 deleted, 6 changed)
OCL=8719937
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/parse_stab.py#10 edit
6 delta lines: 0 added, 0 deleted, 6 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8719937 by [EMAIL PROTECTED] on 2008/10/24 11:42:45 *pending*
Fixes build bustage due to bug in parse_stab.py.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/parse_stab.py#10 edit
==== //depot/googleclient/gears/opensource/gears/tools/parse_stab.py#10 -
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/tools/parse_stab.py ====
# action=edit type=xtext
--- googleclient/gears/opensource/gears/tools/parse_stab.py 2008-10-24
12:36:16.000000000 +0100
+++ googleclient/gears/opensource/gears/tools/parse_stab.py 2008-10-24
12:15:53.000000000 +0100
@@ -322,15 +322,15 @@
for locale, strings in localized_strings.items():
if locale not in LANGUAGE_IDS:
print 'Unknown locale: %s' % locale
- return False
+ return False
lang_id = unicode(LANGUAGE_IDS[locale][1])
sublang_id = unicode(LANGUAGE_IDS[locale][2])
- outputi.append((u'\n'
- u'LANGUAGE %s, %s'
- u'STRINGTABLE DISCARDABLE'
- u'BEGIN'
- u' IDS_LOCALE "%s"\n') % (lang_id, sublang_id, locale))
+ output.append((u'\n'
+ u'LANGUAGE %s, %s\n'
+ u'STRINGTABLE DISCARDABLE\n'
+ u'BEGIN\n'
+ u' IDS_LOCALE "%s"\n') % (lang_id, sublang_id, locale))
for string_id, string in strings.items():
string = string.replace('"', r'""')
