Hello andreip, nicolasroard,
I'd like you to do a code review. Please execute
g4 diff -c 8835888
or point your web browser to
http://mondrian/8835888
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 8835888 by [EMAIL PROTECTED] on 2008/11/03 11:43:09 *pending*
Fix failure logic in UpdateTask::DownloadVersion.
If UpdateTask::DownloadVersion() is invoked with no version to
download, it returns true, indicating success, but the caller
- Run() - will immediately assert because it did not set
completed_version. Changed to return false instead.
PRESUBMIT=passed
R=andreip,nicolasroard
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=8835888
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/common/update_task.cc#12
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 8835888
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8835888 by [EMAIL PROTECTED] on 2008/11/03 11:43:09 *pending*
Fix failure logic in UpdateTask::DownloadVersion.
If UpdateTask::DownloadVersion() is invoked with no version to
download, it returns true, indicating success, but the caller
- Run() - will immediately assert because it did not set
completed_version. Changed to return false instead.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/common/update_task.cc#12
edit
====
//depot/googleclient/gears/opensource/gears/localserver/common/update_task.cc#12
-
/usr/local/google/home/jripley/gears-trunk3/googleclient/gears/opensource/gears/localserver/common/update_task.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/common/update_task.cc
2008-10-27 20:20:27.000000000 +0000
+++ googleclient/gears/opensource/gears/localserver/common/update_task.cc
2008-10-27 16:47:06.000000000 +0000
@@ -507,7 +507,7 @@
WebCacheDB::VersionInfo version;
if (!store_.GetVersion(WebCacheDB::VERSION_DOWNLOADING, &version)) {
LOG(("UpdateTask::DownloadVersion - nothing to download\n"));
- return true;
+ return false;
}
// Find entries that have not yet been filled (downloaded)
