On Tue, Nov 4, 2008 at 11:09 AM, Steve Block <[EMAIL PROTECTED]> wrote:
> > Would renaming the class and files be sufficient? > Currently my CL renames the class to Win32ThreadMesageQueue and moves > it to message_queue_win32. Do you mean that I should also delete > message_queue_ie.cc? Wouldn't this be a little unintuitive? In > general, the message queue is browser-specific, so it seems odd not to > have an IE-specific file. Particularly as Win32ThreadMesageQueue isn't > used for all browsers on Win32. > delete message_queue_ie That is what i meant, just asking the question. I like that there is a single .h file and several different implementations buried in different .cc files. This CL introduces a new .h file which i think could be confusing as well. > > Steve >
