Submitted. ======================================================================== http://mondrian.corp.google.com/file/8716676///depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc (snapshot 5) ------------------------------------ Line 109: if (event_target) { On Fri Nov 7 01:44:20 2008 PST, noel wrote: > event_target is always true here, right? see @96
Done. ======================================================================== http://mondrian.corp.google.com/file/8716676///depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc?a=3 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc (snapshot 3) ------------------------------------ Line 99: } On Fri Nov 7 01:27:38 2008 PST, noel wrote: > delete line 96 and just return drop_target.release(); adjust the comment @304 A scoped_refptr does not have a release method (it is explicitly commented out). ======================================================================== http://mondrian.corp.google.com/file/8716676///depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.h?a=3 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.h (snapshot 3) ------------------------------------ Line 51: // failed). On Fri Nov 7 01:34:13 2008 PST, noel wrote: > does this comment mean to suggest that IElementBehavoir's are somehow broken? > they are not. shrink this comment to the first sentence only. Done. ------------------------------------ Line 84: On Fri Nov 7 01:36:23 2008 PST, noel wrote: > html_window_2_ should be private? Done. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/8716676
