Is that conventional? I thought DOM callbacks generally returned *true* to indicate "yes, I understood what you wanted and I did something".
On Sun, Nov 9, 2008 at 9:13 PM, Nigel Tao <[EMAIL PROTECTED]> wrote: > Hello noel, > > I'd like you to do a code review. Please execute > g4 diff -c 8930787 > > or point your web browser to > http://mondrian/8930787 > > to review the following code: > > Change 8930787 by [EMAIL PROTECTED] on 2008/11/10 16:11:56 *pending* > > ondragenter and ondragover now need to return false to accept Gears' > DnD. > > R=noel > [EMAIL PROTECTED] > DELTA=112 (69 added, 3 deleted, 40 changed) > OCL=8930787 > > Affected files ... > > ... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc#10 > edit > ... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.h#6 > edit > ... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#10 > edit > ... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.h#7 > edit > ... > //depot/googleclient/gears/opensource/gears/test/manual/drag_and_drop.html#7 > edit > > 112 delta lines: 69 added, 3 deleted, 40 changed > > Also consider running: > g4 lint -c 8930787 > > which verifies that the changelist doesn't introduce new style violations. > > If you can't do the review, please let me know as soon as possible. During > your review, please ensure that all new code has corresponding unit tests and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or suggestions? > Mail [EMAIL PROTECTED] >
