Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8578651
or point your web browser to
http://mondrian/8578651
to review the following code:
Change 8578651 by [EMAIL PROTECTED] on 2008/10/13 18:00:54 *pending*
Fixes a couple of log statements in position_table.
R=andreip
[EMAIL PROTECTED]
DELTA=2 (0 added, 0 deleted, 2 changed)
OCL=8578651
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/position_table.cc#4
edit
2 delta lines: 0 added, 0 deleted, 2 changed
Also consider running:
g4 lint -c 8578651
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8578651 by [EMAIL PROTECTED] on 2008/10/13 18:00:54 *pending*
Fixes a couple of log statements in position_table.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/position_table.cc#4
edit
====
//depot/googleclient/gears/opensource/gears/base/common/position_table.cc#4 -
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/base/common/position_table.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/position_table.cc
2008-11-10 10:32:21.000000000 +0000
+++ googleclient/gears/opensource/gears/base/common/position_table.cc
2008-10-13 17:00:36.000000000 +0100
@@ -102,11 +102,11 @@
return false;
}
if (SQLITE_OK != statement.bind_double(4, position.accuracy)) {
- LOG_BIND_ERROR("horizontal accuracy");
+ LOG_BIND_ERROR("accuracy");
return false;
}
if (SQLITE_OK != statement.bind_double(5, position.altitude_accuracy)) {
- LOG_BIND_ERROR("vertical accuracy");
+ LOG_BIND_ERROR("altitude accuracy");
return false;
}
if (SQLITE_OK != statement.bind_int64(6, position.timestamp)) {
