Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8936450
or point your web browser to
http://mondrian/8936450
to review the following code:
Change 8936450 by [EMAIL PROTECTED] on 2008/11/10 17:44:11 *pending*
Deletes some lines from the Makefile which remove files from the Chrome
build that were never included in the build.
R=andreip
[EMAIL PROTECTED]
DELTA=4 (0 added, 4 deleted, 0 changed)
OCL=8936450
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#204 edit
4 delta lines: 0 added, 4 deleted, 0 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8936450 by [EMAIL PROTECTED] on 2008/11/10 17:44:11 *pending*
Deletes some lines from the Makefile which remove files from the Chrome
build that were never included in the build.
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#204 edit
==== //depot/googleclient/gears/opensource/gears/Makefile#204 -
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/Makefile ====
# action=edit type=text
--- googleclient/gears/opensource/gears/Makefile 2008-11-10
18:30:01.000000000 +0000
+++ googleclient/gears/opensource/gears/Makefile 2008-11-10
17:41:16.000000000 +0000
@@ -2487,12 +2487,8 @@
# Remove some files that we don't want to compile for Chrome.
NPAPI_CPPSRCS := $(subst http_cookies.cc,,$(NPAPI_CPPSRCS))
-NPAPI_CPPSRCS := $(subst http_request_ie.cc,,$(NPAPI_CPPSRCS))
-NPAPI_CPPSRCS := $(subst http_handler_ie.cc,,$(NPAPI_CPPSRCS))
NPAPI_CPPSRCS := $(subst js_runner_np.cc,,$(NPAPI_CPPSRCS))
-NPAPI_CPPSRCS := $(subst urlmon_utils.cc,,$(NPAPI_CPPSRCS))
NPAPI_CPPSRCS := $(subst update_task_np.cc,,$(NPAPI_CPPSRCS))
-NPAPI_CPPSRCS := $(subst paths_np.cc,,$(NPAPI_CPPSRCS))
NPAPI_CPPSRCS := $(subst settings_dialog.cc,,$(NPAPI_CPPSRCS))
endif
endif
