Hello playmobil,
I'd like you to do a code review. Please execute
g4 diff -c 8945338
or point your web browser to
http://mondrian/8945338
to review the following code:
Change 8945338 by [EMAIL PROTECTED] on 2008/11/10 17:20:59 *pending*
Fix the broken WinCE build
R=playmobil
[EMAIL PROTECTED]
DELTA=13 (8 added, 0 deleted, 5 changed)
OCL=8945338
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#3
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.h#1
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.cc#17
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.h#14
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc#14
edit
13 delta lines: 8 added, 0 deleted, 5 changed
Also consider running:
g4 lint -c 8945338
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8945338 by [EMAIL PROTECTED] on 2008/11/10 17:20:59 *pending*
Fix the broken WinCE build
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#3
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.h#1
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.cc#17
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.h#14
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc#14
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#3
-
c:\src-gears3/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
2008-11-10 17:21:02.000000000 -0800
+++ googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
2008-11-10 17:08:59.000000000 -0800
@@ -46,16 +46,19 @@
GpsLocationProvider::NewGpsDevice;
LocationProviderBase *NewGpsLocationProvider(
+ BrowsingContext *browsing_context,
const std::string16 &reverse_geocode_url,
const std::string16 &host_name,
const std::string16 &address_language) {
- return new GpsLocationProvider(reverse_geocode_url,
+ return new GpsLocationProvider(browsing_context,
+ reverse_geocode_url,
host_name,
address_language);
}
GpsLocationProvider::GpsLocationProvider(
+ BrowsingContext *browsing_context,
const std::string16 &reverse_geocode_url,
const std::string16 &host_name,
const std::string16 &address_language)
@@ -69,7 +72,8 @@
reverse_geocoder_(NULL),
earliest_reverse_geocode_time_(0),
is_address_requested_(false),
- gps_device_(NULL) {
+ gps_device_(NULL),
+ browsing_context_(browsing_context) {
// Open the device
gps_device_.reset((*gps_device_factory_function_)(this));
// Start the worker thread.
@@ -362,7 +366,7 @@
// We must make all requests from the same thread - the run loop.
// Note that this will fail if a request is already in progress.
assert(reverse_geocoder_.get());
- if (!reverse_geocoder_->MakeRequest(position_)) {
+ if (!reverse_geocoder_->MakeRequest(browsing_context_, position_)) {
assert(false);
}
}
====
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.h#1
-
c:\src-gears3/googleclient/gears/opensource/gears/geolocation/gps_location_provider.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/gps_location_provider.h
2008-11-10 17:21:02.000000000 -0800
+++ googleclient/gears/opensource/gears/geolocation/gps_location_provider.h
2008-11-10 17:09:00.000000000 -0800
@@ -69,7 +69,8 @@
public ReverseGeocoder::ReverseGeocoderListenerInterface,
public GpsDeviceBase::ListenerInterface {
public:
- GpsLocationProvider(const std::string16 &reverse_geocode_url,
+ GpsLocationProvider(BrowsingContext *browsing_context,
+ const std::string16 &reverse_geocode_url,
const std::string16 &host_name,
const std::string16 &address_language);
virtual ~GpsLocationProvider();
@@ -138,6 +139,7 @@
ListenerVector new_listeners_requiring_address_;
bool is_address_requested_;
Mutex address_mutex_;
+ BrowsingContext *browsing_context_;
// The GPS device itself.
scoped_ptr<GpsDeviceBase> gps_device_;
====
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.cc#17
-
c:\src-gears3/googleclient/gears/opensource/gears/geolocation/location_provider.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/location_provider.cc
2008-11-10 17:21:02.000000000 -0800
+++ googleclient/gears/opensource/gears/geolocation/location_provider.cc
2008-11-10 17:13:08.000000000 -0800
@@ -86,6 +86,7 @@
defined(OS_MACOSX)
LocationProviderBase *NewGpsLocationProvider(
+ BrowsingContext *browsing_context,
const std::string16 &reverse_geocode_url,
const std::string16 &host_name,
const std::string16 &address_language) {
====
//depot/googleclient/gears/opensource/gears/geolocation/location_provider.h#14
-
c:\src-gears3/googleclient/gears/opensource/gears/geolocation/location_provider.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/location_provider.h
2008-11-10 17:21:02.000000000 -0800
+++ googleclient/gears/opensource/gears/geolocation/location_provider.h
2008-11-10 17:12:54.000000000 -0800
@@ -93,6 +93,7 @@
// the platform-dependent implementations.
LocationProviderBase *NewMockLocationProvider();
LocationProviderBase *NewGpsLocationProvider(
+ BrowsingContext *browsing_context,
const std::string16 &reverse_geocode_url,
const std::string16 &host_name,
const std::string16 &address_language);
====
//depot/googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc#14
-
c:\src-gears3/googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc
2008-11-10 17:21:02.000000000 -0800
+++ googleclient/gears/opensource/gears/geolocation/location_provider_pool.cc
2008-11-10 17:16:08.000000000 -0800
@@ -141,7 +141,7 @@
return NULL;
#endif // USING_CCTESTS
} else if (type == kGpsString) {
- return NewGpsLocationProvider(url, host, language);
+ return NewGpsLocationProvider(browsing_context, url, host, language);
} else if (type == kNetworkString) {
return NewNetworkLocationProvider(browsing_context, url, host, language);
}
