Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 8953915
or point your web browser to
http://mondrian/8953915
to review the following code:
Change 8953915 by [EMAIL PROTECTED] on 2008/11/11 17:17:20 *pending*
Fixes failing workerpool test testRedirectToCrossOrigin().
Not all browsers report the line number correctly, so we don't test
this.
R=andreip
[EMAIL PROTECTED]
DELTA=2 (0 added, 1 deleted, 1 changed)
OCL=8953915
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js#6
edit
2 delta lines: 0 added, 1 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8953915 by [EMAIL PROTECTED] on 2008/11/11 17:17:20 *pending*
Fixes failing workerpool test testRedirectToCrossOrigin().
Not all browsers report the line number correctly, so we don't test
this.
OCL=8953915
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js#6
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js#6
-
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js
====
# action=edit type=text
---
googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js
2008-11-11 17:17:14.000000000 +0000
+++
googleclient/gears/opensource/gears/test/testcases/workerpool_createworkerfromurl_tests.js
2008-11-12 11:26:15.000000000 +0000
@@ -167,8 +167,7 @@
// test relies on the redirected origin not already having local storage
// permissions.
var wp = google.gears.factory.create('beta.workerpool');
- var expectedError = 'Error in worker 1 at line 21. Page does not have ' +
- 'permission to use Google Gears.';
+ var expectedError = 'Page does not have permission to use Google Gears.';
var workerUrl = differentOrigin2 + crossOriginWorkerPath;
var childId = wp.createWorkerFromUrl(redirectPath + workerUrl);
