Hello steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 8975030
or point your web browser to
http://mondrian/8975030
to review the following code:
Change 8975030 by [EMAIL PROTECTED] on 2008/11/12 11:45:47 *pending*
Add a missing free to GetPropertyNames for NPAPI
R=steveblock
[EMAIL PROTECTED]
DELTA=3 (3 added, 0 deleted, 0 changed)
OCL=8975030
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/js_types.cc#51 edit
3 delta lines: 3 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 8975030
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 8975030 by [EMAIL PROTECTED] on 2008/11/12 11:45:47 *pending*
Add a missing free to GetPropertyNames for NPAPI
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/js_types.cc#51 edit
==== //depot/googleclient/gears/opensource/gears/base/common/js_types.cc#51 -
c:\src-gears3/googleclient/gears/opensource/gears/base/common/js_types.cc ====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/common/js_types.cc 2008-11-12
11:42:18.000000000 -0800
+++ googleclient/gears/opensource/gears/base/common/js_types.cc 2008-11-12
11:11:14.000000000 -0800
@@ -797,6 +797,9 @@
return false;
}
out->push_back(name);
+ }
+ if (count) {
+ NPN_MemFree(identifiers);
}
return true;
}
