> ======================================================================== > http://mondrian.corp.google.com/file/8950885///depot/googleclient/gears/opensource/gears/installer/opera/setup.cc?a=1 > File //depot/googleclient/gears/opensource/gears/installer/opera/setup.cc > (snapshot 1) > ------------------------------------ > Line 27: > Maybe we can avoid duplicating this file? The version for IE includes code to handle registry entries which we don't need for Opera. Also, the code to kill and restart the two browsers is slightly different. I'm not sure it's worth it.
> ------------------------------------ > Line 67: NULL); > whitespace Done > ======================================================================== > http://mondrian.corp.google.com/file/8950885///depot/googleclient/gears/opensource/gears/tools/config.mk?a=1 > File //depot/googleclient/gears/opensource/gears/tools/config.mk (snapshot 1) > ------------------------------------ > Line 730: NPAPI_LIBS = wininet.lib ceshell.lib coredll.lib corelibc.lib > ole32.lib oleaut32.lib uuid.lib commctrl.lib atlosapis.lib piedocvw.lib > cellcore.lib htmlview.lib imaging.lib toolhelp.lib aygshell.lib iphlpapi.lib > gpsapi.lib > Have WINCE_LIBS and use it for both Opera and PIE? Done. Also removed unused libs for Opera. > ------------------------------------ > Line 732: NPAPI_LIBS = delayimp.lib /DELAYLOAD:"comdlg32.dll" comdlg32.lib > Make sure we don't pick this up. Done > ======================================================================== > http://mondrian.corp.google.com/file/8950885///depot/googleclient/gears/opensource/gears/tools/rules.mk?a=1 > File //depot/googleclient/gears/opensource/gears/tools/rules.mk (snapshot 1) > ------------------------------------ > Line 424: ifeq ($(OS),wince) > Comment on the fact that Opera desktop is coming soon. Done New snapshot uploaded.
