Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 9009039
or point your web browser to
http://mondrian/9009039
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 9009039 by [EMAIL PROTECTED] on 2008/11/14 10:17:42 *pending*
* Don't compile Safari Drag & Drop hooks in OFFICIAL_BUILD.
* When loading D&D Hooks, log errors in release mode.
PRESUBMIT=passed
R=aa
[EMAIL PROTECTED]
DELTA=10 (8 added, 0 deleted, 2 changed)
OCL=9009039
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#208 edit
...
//depot/googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm#13
edit
10 delta lines: 8 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9009039 by [EMAIL PROTECTED] on 2008/11/14 10:17:42 *pending*
* Don't compile Safari Drag & Drop hooks in OFFICIAL_BUILD.
* When loading D&D Hooks, log errors in release mode.
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#208 edit
...
//depot/googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm#13
edit
==== //depot/googleclient/gears/opensource/gears/Makefile#208 -
/Users/playmobil/Documents/dev/gears/googleclient/gears/opensource/gears/Makefile
====
# action=edit type=text
--- googleclient/gears/opensource/gears/Makefile 2008-11-14
10:22:11.000000000 -0800
+++ googleclient/gears/opensource/gears/Makefile 2008-11-14
10:20:03.000000000 -0800
@@ -1445,10 +1445,14 @@
desktop_cr.cc \
$(NULL)
+ifeq ($(OFFICIAL_BUILD),1)
+# The Drag-and-Drop API has not been finalized for official builds.
+else
SF_CPPSRCS += \
drag_and_drop_utils_osx.mm \
drop_target_sf.cc \
$(NULL)
+endif # not OFFICIAL_BUILD
#-----------------------------------------------------------------------------
# gtest
====
//depot/googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm#13
-
/Users/playmobil/Documents/dev/gears/googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm
2008-11-14 10:22:11.000000000 -0800
+++ googleclient/gears/opensource/gears/base/safari/browser_load_hook.mm
2008-11-14 09:40:41.000000000 -0800
@@ -110,12 +110,16 @@
LOG(("Gears: notification hook already installed"));
}
- NSLog(@"Gears: Swizzling WebView methods");
+#ifdef OFFICIAL_BUILD
+ // The Drag-and-Drop API has not been finalized for official builds.
+#else
+ LOG(("Gears: Swizzling WebView methods"));
if (!SwizzleWebViewMethods()) {
NSLog(@"Gears: Swizzling WebView methods failed");
return NO;
}
- NSLog(@"Gears: Swizzling WebView methods succeeded");
+ LOG(("Gears: Swizzling WebView methods succeeded"));
+#endif
// If we got here then we loaded OK
LOG(("Loaded Gears version: " PRODUCT_VERSION_STRING_ASCII "\n" ));
