Hello steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 9033080
or point your web browser to
http://mondrian/9033080
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 9033080 by [EMAIL PROTECTED] on 2008/11/17 14:38:38 *pending*
Fix 2 trivial Geolocation compile warnings.
The format of a LOG() string in geolocation.cc is incorrect,
and should use %d instead of %s. This only happens in a case
when a bad enumeration value is used and would assert(false)
anyway.
The initialization order of two variables in class
GpsLocationProvider needs swapping: browsing_context_ and
gps_device_. This needs to match the declaration order.
PRESUBMIT=passed
R=steveblock
[EMAIL PROTECTED]
DELTA=3 (0 added, 0 deleted, 3 changed)
OCL=9033080
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#31
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#4
edit
3 delta lines: 0 added, 0 deleted, 3 changed
Also consider running:
g4 lint -c 9033080
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9033080 by [EMAIL PROTECTED] on 2008/11/17 14:38:38 *pending*
Fix 2 trivial Geolocation compile warnings.
The format of a LOG() string in geolocation.cc is incorrect,
and should use %d instead of %s. This only happens in a case
when a bad enumeration value is used and would assert(false)
anyway.
The initialization order of two variables in class
GpsLocationProvider needs swapping: browsing_context_ and
gps_device_. This needs to match the declaration order.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#31
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#4
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc#31
-
/usr/local/google/home/jripley/gears-trunk/googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
2008-11-17 14:38:45.000000000 +0000
+++ googleclient/gears/opensource/gears/geolocation/geolocation_test.cc
2008-11-17 14:35:34.000000000 +0000
@@ -461,7 +461,7 @@
radio_data.radio_type = RADIO_TYPE_WCDMA;
break;
default:
- LOG(("ConfigureGeolocationRadioDataProviderForTest() : Ignoring value %s
"
+ LOG(("ConfigureGeolocationRadioDataProviderForTest() : Ignoring value %d
"
"for radio_type.\n", radio_type));
}
GetStringPropertyIfDefined(context, object.get(), kCarrierString,
====
//depot/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc#4
-
/usr/local/google/home/jripley/gears-trunk/googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
2008-11-17 14:38:45.000000000 +0000
+++ googleclient/gears/opensource/gears/geolocation/gps_location_provider.cc
2008-11-17 14:36:21.000000000 +0000
@@ -72,8 +72,8 @@
reverse_geocoder_(NULL),
earliest_reverse_geocode_time_(0),
is_address_requested_(false),
- gps_device_(NULL),
- browsing_context_(browsing_context) {
+ browsing_context_(browsing_context),
+ gps_device_(NULL) {
// Open the device
gps_device_.reset((*gps_device_factory_function_)(this));
// Start the worker thread.
