Hello playmobil,
I'd like you to do a code review. Please execute
g4 diff -c 9044761
or point your web browser to
http://mondrian/9044761
to review the following code:
Change 9044761 by [EMAIL PROTECTED] on 2008/11/18 12:19:06 *pending*
Gears/Safari is no longer a windowless NPAPI plug-in, which makes
it work in trunk WebKit.
PRESUBMIT=passed
R=playmobil
[EMAIL PROTECTED]
DELTA=6 (5 added, 0 deleted, 1 changed)
OCL=9044761
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc#9
edit
6 delta lines: 5 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9044761
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9044761 by [EMAIL PROTECTED] on 2008/11/18 12:19:06 *pending*
Gears/Safari is no longer a windowless NPAPI plug-in, which makes
it work in trunk WebKit.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc#9
edit
==== //depot/googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc#9 -
/Users/nigeltao/devel/srcmacgears1/googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc
2008-11-18 12:14:55.000000000 +1100
+++ googleclient/gears/opensource/gears/base/npapi/npp_bindings.cc
2008-11-18 12:17:13.000000000 +1100
@@ -100,8 +100,13 @@
UTF8ToString16(user_agent_utf8, &g_user_agent);
}
- // Make this a windowless plugin.
+#if BROWSER_CHROME
+ // TODO(nigeltao): Is it really necessary (in Chrome) to make this a
+ // windowless plugin?
return NPN_SetValue(instance, NPPVpluginWindowBool, NULL);
+#else
+ return NPERR_NO_ERROR;
+#endif
}
// here is the place to clean up and destroy the NPObject object
