Thanks Baran. > ======================================================================== > http://mondrian.corp.google.com/file/9034220///depot/googleclient/gears/opensource/gears/test/testcases/cgi/reverse_geocoder.py?a=1 > File > //depot/googleclient/gears/opensource/gears/test/testcases/cgi/reverse_geocoder.py > (snapshot 1) > ------------------------------------ > Line 10: """ > If the comment is a one-liner, you don't need a line break before the closing > """. Done
> ------------------------------------ > Line 28: location = self.request["location"] > Tab and whitespace at the end of the line. Done > ------------------------------------ > Line 32: > Two blank lines required between top level module members. Done > ------------------------------------ > Line 55: > Two blank lines required. Done > ======================================================================== > http://mondrian.corp.google.com/file/9034220///depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js?a=1 > File > //depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js > (snapshot 1) > ------------------------------------ > Line 508: if (isWince || isAndroid) { > How about > if !( isWinCE || Android) { > return; > } The pattern elsewhere in these JS test files is to use nested ifs, rather than early returns, so I think it's best left as it is. New snapshot uploaded.
