Nice. ======================================================================== http://mondrian.corp.google.com/file/9069369///depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc?a=2 File //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc (snapshot 2) ------------------------------------ Line 456: } Should we factor out the block above and the one below into "TimeoutExpiredImpl()"and "CallbackRequiredImpl()" respectively? Then OnNotify becomes simpler and easier to follow. ------------------------------------ Line 595: if (!RecordNewFixRequest(info.get(), &fix_request_id)) { Were we leaking this in case of failures? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9069369
