Hello andreip, michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 9135356
or point your web browser to
http://mondrian/9135356
to review the following code:
Change 9135356 by [EMAIL PROTECTED] on 2008/11/24 16:35:04 *pending*
Fixes build bustage due to type mismatch in json_reader.cc.
R=andreip,michaeln
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9135356
Affected files ...
... //depot/googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc#3
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9135356
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9135356 by [EMAIL PROTECTED] on 2008/11/24 16:35:04 *pending*
Fixes build bustage due to type mismatch in json_reader.cc.
Affected files ...
... //depot/googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc#3
edit
==== //depot/googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc#3
-
c:\MyDocs\Gears3/googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc
====
# action=edit type=text
--- googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc
2008-11-24 17:11:41.000000000 +0000
+++ googleclient/gears/opensource/third_party/jsoncpp/json_reader.cc
2008-11-24 16:33:03.000000000 +0000
@@ -78,7 +78,7 @@
{
// Advance over a UTF-8 BOM if present
const char kBOM[] = { 0xEF, 0xBB, 0xBF };
- if (endDoc - beginDoc >= sizeof(kBOM)) {
+ if (endDoc - beginDoc >= static_cast<int>(sizeof(kBOM))) {
if (beginDoc[0] == kBOM[0] &&
beginDoc[1] == kBOM[1] &&
beginDoc[2] == kBOM[2]) {
