Hello michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 9141145
or point your web browser to
http://mondrian/9141145
to review the following code:
Change 9141145 by [EMAIL PROTECTED] on 2008/11/24 14:10:38 *pending*
Add documentation for the Database::remove() method.
PRESUBMIT=passed
R=michaeln
[EMAIL PROTECTED]
DELTA=16 (15 added, 0 deleted, 1 changed)
OCL=9141145
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_database.html#5 edit
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#9 edit
16 delta lines: 15 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9141145 by [EMAIL PROTECTED] on 2008/11/24 14:10:38 *pending*
Add documentation for the Database::remove() method.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_database.html#5 edit
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#9 edit
==== //depot/googleclient/gears/opensource/gears/sdk/api_database.html#5 -
c:\src-gears2/googleclient/gears/opensource/gears/sdk/api_database.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_database.html 2008-11-24
14:12:01.000000000 -0800
+++ googleclient/gears/opensource/gears/sdk/api_database.html 2008-11-24
13:53:31.000000000 -0800
@@ -95,6 +95,7 @@
void <b>open</b>([name])
ResultSet <b>execute</b>(sqlStatement, [argArray])
void <b>close</b>()
+ void <b>remove</b>()
readonly attribute int <b>lastInsertRowId</b>
readonly attribute int <b>rowsAffected</b>
</code></pre>
@@ -213,6 +214,19 @@
instance. Calling Database.close() is not required.<br />
<br />
</td></tr>
+</table>
+<table>
+ <tr class="odd">
+ <th colspan="2"><a href="#Database-remove" name="Database-remove"
class="code">remove()</a></th>
+ </tr>
+ <tr class="odd">
+ <td width="113">Return value: </td>
+ <td width="489" class="code">void</td>
+ </tr>
+ <tr class="odd">
+ <td>Description:</td>
+ <td class="odd">Completely deletes the currently opened database. Closes
the database first if necessary.</td>
+ </tr>
</table>
<table>
<tr class="odd">
==== //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#9 -
c:\src-gears2/googleclient/gears/opensource/gears/sdk/api_summary.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_summary.html 2008-11-24
14:12:01.000000000 -0800
+++ googleclient/gears/opensource/gears/sdk/api_summary.html 2008-11-24
14:11:20.000000000 -0800
@@ -71,7 +71,8 @@
readonly attribute int <b>rowsAffected</b>
void <b>open</b>([name])
ResultSet <b>execute</b>(sqlStatement, [argArray])
- void <b>close</b>()</code></pre>
+ void <b>close</b>()
+ void <b>remove</b>()</code></pre>
<pre><code><a href="api_database.html">ResultSet class</a>
boolean <b>isValidRow</b>()
