Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 9147521
or point your web browser to
http://mondrian/9147521
to review the following code:
Change 9147521 by [EMAIL PROTECTED] on 2008/11/25 15:51:02 *pending*
Build fix for Visual Studio - there was a compiler warning
about operator precedence.
R=noel
[EMAIL PROTECTED]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9147521
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#1
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9147521
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9147521 by [EMAIL PROTECTED] on 2008/11/25 15:51:02 *pending*
Build fix for Visual Studio - there was a compiler warning
about operator precedence.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#1
edit
====
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#1
-
c:\devel\srcwingears2/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
2008-11-25 15:50:29.000000000 +1100
+++ googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
2008-11-25 15:44:17.000000000 +1100
@@ -173,7 +173,7 @@
// made, during nsEventDispatcher::Dispatch in
// mozilla/content/events/src/nsEventDispatcher.cpp, and so this bit-check is
// a meaningful test. The nsEventDispatcher class is new in Gecko 1.9.
- if (ns_event->flags & NS_EVENT_FLAG_DISPATCHING == 0) {
+ if (((ns_event->flags) & NS_EVENT_FLAG_DISPATCHING) == 0) {
return DRAG_AND_DROP_EVENT_INVALID;
}
#endif
