Hello steveblock,
I'd like you to do a code review. Please execute
g4 diff -c 9170922
or point your web browser to
http://mondrian/9170922
to review the following code:
Change 9170922 by [EMAIL PROTECTED] on 2008/11/26 16:37:25 *pending*
Fix for Geolocation MakeTimeoutExpiredCallback: make sure only one-shot
fix requests are automatically deleted after an errorCallback(TIMEOUT) call.
PRESUBMIT=passed
R=steveblock
[EMAIL PROTECTED]
DELTA=7 (6 added, 0 deleted, 1 changed)
OCL=9170922
Affected files ...
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#65
edit
7 delta lines: 6 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9170922
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
