Hello michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 9198974
or point your web browser to
http://mondrian/9198974
to review the following code:
Change 9198974 by [EMAIL PROTECTED] on 2008/11/29 00:00:56 *pending*
Catch up some missing updates to api_summary.html.
PRESUBMIT=passed
R=michaeln
[EMAIL PROTECTED]
DELTA=11 (9 added, 0 deleted, 2 changed)
OCL=9198974
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#10 edit
11 delta lines: 9 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9198974 by [EMAIL PROTECTED] on 2008/11/29 00:00:56 *pending*
Catch up some missing updates to api_summary.html.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#10 edit
==== //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#10 -
c:\src-gears2/googleclient/gears/opensource/gears/sdk/api_summary.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_summary.html 2008-11-29
00:01:35.000000000 -0800
+++ googleclient/gears/opensource/gears/sdk/api_summary.html 2008-11-29
00:00:18.000000000 -0800
@@ -142,10 +142,17 @@
string <b>getAllResponseHeaders</b>()
callback <b>onreadystatechange</b>
readonly attribute int <b>readyState</b>
+ readonly attribute Blob <b>responseBlob</b>
readonly attribute string <b>responseText</b>
readonly attribute int <b>status</b>
- readonly attribute string <b>statusText</b></code></pre>
-
+ readonly attribute string <b>statusText</b>
+ readonly attribute HttpRequestUpload <b>upload</b></code></pre>
+<pre><code><a href="api_httprequest.html#HttpRequestUpload">HttpRequestUpload
class</a>
+ callback <b>onprogress</b>(progressEvent)</code></pre>
+<pre><code><a href="api_httprequest.html#ProgressEvent">ProgressEvent class</a>
+ readonly attribute int <b>total</b>
+ readonly attribute int <b>loaded</b>
+ readonly attribute bool <b>lengthComputable</b></code></pre>
<h3>LocalServer</h3>
<p>Caches and serves your application's resources locally, making it possible
to start a web application without a network connection. </p>
@@ -182,7 +189,9 @@
void <b>rename</b>(srcUrl, destUrl)
void <b>copy</b>(srcUrl, destUrl)
boolean <b>isCaptured</b>(url)
+ void <b>captureBlob</b>(blob, url, [contentType])
void <b>captureFile</b>(fileInputElement, url)
+ Blob <b>getAsBlob</b>(url)
string <b>getCapturedFileName</b>(url)
string <b>getHeader</b>(url, name)
string <b>getAllHeaders</b>(url)