LGTM

> is there a preferred way to do this?

Yeah, the GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM thing is a
little ugly at the moment. I think your approach is fine.

========================================================================
http://mondrian.corp.google.com/file/9193304///depot/googleclient/gears/opensource/gears/desktop/desktop.cc?a=1
File //depot/googleclient/gears/opensource/gears/desktop/desktop.cc (snapshot 1)
------------------------------------
Line 1051: #if BROWSER_FF || BROWSER_IE || BROWSER_WEBKIT
This change shouldn't be necessary, because we're inside an
#if GEARS_DRAG_AND_DROP_API_IS_SUPPORTED_FOR_THIS_PLATFORM
right?
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/9193304

Reply via email to