LGTM++ ======================================================================== http://mondrian.corp.google.com/file/9228479///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc (snapshot 1) ------------------------------------ Line 483: PRInt64 file_size; No problem, and you added the TODO as well. Thankyou. ======================================================================== http://mondrian.corp.google.com/file/9228479///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc?a=2 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc (snapshot 2) ------------------------------------ Line 505: // that is, does the file extension include the dot at the start. use whatever File::GetFileExtension(filename.get())) returns ------------------------------------ Line 507: // TODO(nigeltao): Should we also keep an array of per-file MIME types, yes. ======================================================================== http://mondrian.corp.google.com/file/9228479///depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc (snapshot 1) ------------------------------------ Line 235: // aggregate file metadata) during dragenter, dragover and dragleave, make take would be: dragenter(required), dragover(required/nice to have), dragleave (not needed/won't hurt), drop (not needed). ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9228479
