Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9266312
or point your web browser to
http://mondrian/9266312
to review the following code:
Change 9266312 by [EMAIL PROTECTED] on 2008/12/04 16:38:27 *pending*
Modifies WinCE inf files to prevent dialog asing user to select instal
location when installing Gears CAB.
This is achieved by simply moving the definition of the 'InstallDir'
string from the 'CEStrings' section to the 'Strings' section of the inf file.
It seems that a string named 'InstallDir' in the 'CEStrings' section has
special meaning and causes the installer to prompt the user for the install
location. See http://msdn.microsoft.com/en-us/library/aa924361.aspx.
R=andreip
[EMAIL PROTECTED]
DELTA=3 (1 added, 1 deleted, 1 changed)
OCL=9266312
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_ie.inf.m4#1
edit
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#1
edit
3 delta lines: 1 added, 1 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9266312 by [EMAIL PROTECTED] on 2008/12/04 16:38:27 *pending*
Modifies WinCE inf files to prevent dialog asing user to select instal
location when installing Gears CAB.
This is achieved by simply moving the definition of the 'InstallDir'
string from the 'CEStrings' section to the 'Strings' section of the inf file.
It seems that a string named 'InstallDir' in the 'CEStrings' section has
special meaning and causes the installer to prompt the user for the install
location. See http://msdn.microsoft.com/en-us/library/aa924361.aspx.
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_ie.inf.m4#1
edit
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#1
edit
====
//depot/googleclient/gears/opensource/gears/installer/wince_cab_ie.inf.m4#1 -
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/installer/wince_cab_ie.inf.m4
====
# action=edit type=binary
bTRfY2hhbmdlcXVvdGUoYF4nLGBeJyltNF9kbmwKCltWZXJzaW9uXQpTaWduYXR1cmU9IiRXaW5k
b3dzIE5UJCIKUHJvdmlkZXI9Ikdvb2dsZSIgIDtbbmFtaW5nXQpDRVNpZ25hdHVyZT0iJFdpbmRv
d3MgQ0UkIgoKW0NFRGV2aWNlXQpWZXJzaW9uTWluPTQuMApWZXJzaW9uTWF4PTYuOTkKQnVpbGRN
YXg9MHhFMDAwMDAwMAoKOyBTdHJpbmcgYWxpYXNlcyBmb3IgY29udmVuaWVuY2UKW1N0cmluZ3Nd
Cm00X2lmZWxzZShERUJVRyxeMV4sXm00X2RubApCdWlsZE91dHB1dERpcmVjdG9yeT0iYmluLWRi
Z1x3aW5jZS1hcm1caWUiCl4sXjFeLF4xXixebTRfZG5sCkJ1aWxkT3V0cHV0RGlyZWN0b3J5PSJi
aW4tb3B0XHdpbmNlLWFybVxpZSIKXikKU2V0dXBEbGw9InNldHVwLmRsbCIKR2VhcnNEbGw9IlBS
T0RVQ1RfU0hPUlRfTkFNRV9VUS5kbGwiCkluc3RhbGxEaXI9IiVDRTElXFBST0RVQ1RfRlJJRU5E
TFlfTkFNRV9VUSIKCltDRVN0cmluZ3NdCjsgU2hvdWxkIGJlICdHZWFycyBmb3IgSW50ZXJuZXQg
RXhwbG9yZXInLCBidXQgaXMgbGVmdCBhcy1pcyBmb3IKOyBiYWNrd2FyZHMtY29tcGF0aWJpbGl0
eQpBcHBOYW1lPSJHZWFycyIgIDtbbmFtaW5nXQoKOyBUaGUgc291cmNlIGRpcmVjdG9yaWVzIGZv
ciB0aGUgZmlsZXMgdGhhdCB3aWxsIGJlIGluIGluIHRoZSBDQUIKW1NvdXJjZURpc2tzTmFtZXNd
CjE9LCJEbGxTb3VyY2VEaXJlY3RvcnkiLCwlQnVpbGRPdXRwdXREaXJlY3RvcnklCgo7IFRoZSBm
aWxlcyB0aGF0IHdpbGwgYmUgaW4gdGhlIENBQgpbU291cmNlRGlza3NGaWxlc10KJUdlYXJzRGxs
JT0xICA7IEluIERsbFNvdXJjZURpcmVjdG9yeQolU2V0dXBEbGwlPTEgIDsgSW4gRGxsU291cmNl
RGlyZWN0b3J5Cgo7IFRoZSBkZXN0aW5hdGlvbiBkaXJlY3RvcmllcyBmb3IgdGhlIGZpbGVzIHRo
YXQgd2lsbCBiZSBpbiB0aGUgQ0FCCltEZXN0aW5hdGlvbkRpcnNdCkRsbERlc3RpbmF0aW9uRGly
ZWN0b3J5PTAsJUluc3RhbGxEaXIlCgo7IFRoZSBmaWxlcyB0byBnbyBpbiB0aGUgRExMIGRlc3Rp
bmF0aW9uIGRpcmVjdG9yeQpbRGxsRGVzdGluYXRpb25EaXJlY3RvcnldCiVHZWFyc0RsbCUsJUdl
YXJzRGxsJSwsMAoKOyBUaGUgYWN0aW9uIHRvIHRha2UgZHVyaW5nIGluc3RhbGxhdGlvbgpbRGVm
YXVsdEluc3RhbGxdCkNvcHlGaWxlcz1EbGxEZXN0aW5hdGlvbkRpcmVjdG9yeQpDRVNlbGZSZWdp
c3Rlcj0lR2VhcnNEbGwlCkNFU2V0dXBETEw9JVNldHVwRGxsJSAgOyBUaGUgRExMIHRoYXQgZ2V0
cyBydW4gZHVyaW5nIGluc3RhbGxhdGlvbgo=
====
//depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#1 -
c:\MyDocs\Gears4/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
2008-12-04 16:42:48.000000000 +0000
+++ googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
2008-12-04 16:35:10.000000000 +0000
@@ -22,11 +22,11 @@
PermissionsDialog="permissions_dialog.html"
SettingsDialog="settings_dialog.html"
ShortcutsDialog="shortcuts_dialog.html"
+InstallDir="\Application Data\Opera 9.5"
[CEStrings]
; Must be different from that for Gears for IE to avoid conflicts.
AppName="Gears for Opera Mobile" ;[naming]
-InstallDir="\Application Data\Opera 9.5"
; The source directories for the files that will be in in the CAB
[SourceDisksNames]
