LGTM with 2 small nits
======================================================================== http://mondrian.corp.google.com/file/9262838///depot/googleclient/gears/opensource/gears/base/common/mime_detect.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/mime_detect.cc (snapshot 1) ------------------------------------ Line 109: NULL, file_extension.c_str(), file_extension.length())); Perhaps CFStringCreateWithString16()? ======================================================================== http://mondrian.corp.google.com/file/9262838///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_common.cc?a=3 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_common.cc (snapshot 3) ------------------------------------ Line 88: // TODO(nigeltao): Error checking. We should return emtpy (or 0) instead of *emtpy ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9262838
