Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9266679
or point your web browser to
http://mondrian/9266679
to review the following code:
Change 9266679 by [EMAIL PROTECTED] on 2008/12/04 17:02:43 *pending*
Updates api_summary.html with latest changes to Geolocation API.
R=andreip
[EMAIL PROTECTED]
DELTA=6 (6 added, 0 deleted, 0 changed)
OCL=9266679
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#11 edit
6 delta lines: 6 added, 0 deleted, 0 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
Change 9266679 by [EMAIL PROTECTED] on 2008/12/04 17:02:43 *pending*
Updates api_summary.html with latest changes to Geolocation API.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#11 edit
==== //depot/googleclient/gears/opensource/gears/sdk/api_summary.html#11 -
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/sdk/api_summary.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/api_summary.html 2008-12-04
17:20:26.000000000 +0000
+++ googleclient/gears/opensource/gears/sdk/api_summary.html 2008-12-04
17:01:14.000000000 +0000
@@ -95,6 +95,7 @@
<p>Provides a way to obtain a user's geographical position.</p>
<pre><code><a href="api_geolocation.html#geolocation">Geolocation class</a>
readonly attribute Position <b>lastPosition</b>
+ readonly attribute boolean <b>hasPermission</b>
void <b>getCurrentPosition</b>(successCallback, [errorCallback],
[options])
int <b>watchPosition</b>(successCallback, [errorCallback], [options])
void <b>clearWatch</b>(int watchId)
@@ -111,11 +112,16 @@
<pre><code><a href="api_geolocation.html#positionoptions">PositionOptions
class</a>
readwrite attribute bool <b>enableHighAccuracy</b>
+ readwrite attribute int <b>timeout</b>
readwrite attribute bool <b>gearsRequestAddress</b>
readwrite attribute string <b>gearsAddressLanguage</b>
readwrite attribute string[] <b>gearsLocationProviderUrls</b></code></pre>
<pre><code><a href="api_geolocation.html#positionerror">PositionError class</a>
+ readonly attribute int <b>UNKNOWN_ERROR</b>
+ readonly attribute int <b>PERMISSION_DENIED</b>
+ readonly attribute int <b>POSITION_UNAVAILABLE</b>
+ readonly attribute int <b>TIMEOUT</b>
readonly attribute int <b>code</b>
readonly attribute string <b>message</b></code></pre>
