LGTM ======================================================================== http://mondrian.corp.google.com/file/9311198///depot/googleclient/gears/opensource/gears/desktop/desktop.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/desktop.cc (snapshot 1) ------------------------------------ Line 1090: if (flavor_as_string == STRING16(L"Files")) { other data points:
re [2] Webkit case-sensitivity depends on platform. http://trac.webkit.org/browser/trunk/WebCore/platform/win/ClipboardWin.cpp#L78 chrome: case-insensitive http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/platform/chromium/ClipboardChromium.cpp, refer to clipboardTypeFromMIMEType() firefox 3.1b: maybe case-sensitive from cursory reading of the HTML5 drag/drop patches https://bugzilla.mozilla.org/show_bug.cgi?id=356295 And no wonder users get confused and my request that it be case-insensitive (liberal). So maybe [1]'s good enough to say make it "Files" and be done with the issue. ======================================================================== http://mondrian.corp.google.com/file/9311198///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_common.h?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_common.h (snapshot 1) ------------------------------------ Line 45: DRAG_AND_DROP_FLAVOR_INVALID Our coding standard suggests the initializer at the front, but it makes no explicit statement about it, it's just a hint. I'll leave to you to decide. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9311198
