Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9135600
or point your web browser to
http://mondrian/9135600
to review the following code:
Change 9135600 by [EMAIL PROTECTED] on 2008/11/24 16:53:02 *pending*
Adds the Opera Mobile browser API headers and the OperaUtils class for
accessing this API.
As per my last email, the only problems with the CL are minor style
problems. I've just uploaded a new snapshot which fixes all of these. Andrei
and Stig, if you're both happy, I'll submit.
R=andreip
[EMAIL PROTECTED],[email protected]
DELTA=301 (301 added, 0 deleted, 0 changed)
OCL=9135600
Affected files ...
...
//depot/googleclient/gears/opensource/third_party/opera/opera_callback_api.h#1
add
...
//depot/googleclient/gears/opensource/third_party/opera/opera_local_server_interface.h#1
add
...
//depot/googleclient/gears/opensource/third_party/opera/opera_worker_interface.h#1
add
301 delta lines: 301 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 9135600
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [EMAIL PROTECTED]
