LGTM
On Thu, Dec 11, 2008 at 4:41 PM, Andrei Popescu <[email protected]> wrote: > On Fri, Dec 12, 2008 at 12:24 AM, Nigel Tao <[email protected]> wrote: >> ======================================================================== >> http://mondrian.corp.google.com/file/9284351///depot/googleclient/gears/opensource/gears/factory/factory_impl.cc?a=4 >> File //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc >> (snapshot 4) >> ------------------------------------ >> Line 181: REGISTER_GEARS_MODULE(STRING16(L"beta.test"), GearsTest); >> On 6:58 am, michaeln wrote: >>> Uh oh... the Factory doesn't actually have knowledge of all scriptable >>> object >>> types, those that are not directly manufacturable via Create are not >>> accounted >>> for (ie. ResultSet, ResourceStore, GearsHttpRequestUpload). >>> >>> Maybe this wasn't such a good idea after all... sorry for suggesting that >>> you >> go >>> down this road. >> >> Yeah, I think that the set of Gears class names belongs in >> js_runner_ff_marshaling, not in factory_impl. > > Yeah, I should have remembered there were other scriptable objects > created outside the factory! Oh well, too bad, I was proud of my > solution :) I'll submit the version that Michael LGTMed already. > > Andrei >
