On Fri, 12 Dec 2008 16:24:08 +0100, Steve Block <[email protected]>
wrote:
I have only two significant comments. The others are just style nits.
- This makes use of an overloaded version of NewJsRunner() that hasn't
been submitted yet. I'm happy to submit with this call commented out and
a TODO.
Do that for now, and I'll send you the patches for the JsRunner stuff.
- I'm not sure about casting from NPP to JsCallContext.
I'm not either :) I haven't written that code so I honestly don't know why
they do that.
I'll follow up with an updated patch that fixes all of my comments. If
you're
happy with this, I'll submit on your behalf - there's no need to send a
new patch.
That would be great.
--
Stig Halvorsen
Senior Core Developer
Opera Software ASA
