Hello iyengar,
I'd like you to do a code review. Please execute
g4 diff -c 9397026
or point your web browser to
http://mondrian/9397026
to review the following code:
Change 9397026 by mpcompl...@mpcomplete-gears-linux on 2008/12/12 16:26:59
*pending*
Remove WIN32-only guard around boolean define, so libgd builds on linux
and mac.
PRESUBMIT=passed
R=iyengar
[email protected]
DELTA=4 (0 added, 2 deleted, 2 changed)
OCL=9397026
Affected files ...
... //depot/googleclient/gears/opensource/third_party/libjpeg/jconfig.h#2 edit
4 delta lines: 0 added, 2 deleted, 2 changed
Also consider running:
g4 lint -c 9397026
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9397026 by mpcompl...@mpcomplete-gears-linux on 2008/12/12 16:26:59
*pending*
Remove WIN32-only guard around boolean define, so libgd builds on linux
and mac.
Affected files ...
... //depot/googleclient/gears/opensource/third_party/libjpeg/jconfig.h#2 edit
==== //depot/googleclient/gears/opensource/third_party/libjpeg/jconfig.h#2 -
/home/mpcomplete/src/gears/googleclient/gears/opensource/third_party/libjpeg/jconfig.h
====
# action=edit type=text
--- googleclient/gears/opensource/third_party/libjpeg/jconfig.h 2008-12-12
16:27:41.000000000 -0800
+++ googleclient/gears/opensource/third_party/libjpeg/jconfig.h 2008-12-12
16:25:32.000000000 -0800
@@ -59,14 +59,12 @@
/* Define this if you get warnings about undefined structures. */
#undef INCOMPLETE_TYPES_BROKEN
-// Change to allow Gears to compile cross-platform with the same jconfig.h
-#ifdef WIN32
-/* Define "boolean" as unsigned char, not int, per Windows custom */
+/* Define "boolean" as unsigned char, not int, per Windows custom. Do this on
+ * all platforms since that's what libjpeg does. */
#ifndef __RPCNDR_H__ /* don't conflict if rpcndr.h already read */
typedef unsigned char boolean;
#endif
#define HAVE_BOOLEAN /* prevent jmorecfg.h from redefining it */
-#endif
/* defines that need not be visible to callers of the IJG library */
