Stig, if you're happy with the change I've proposed below, I can submit it for you. There's no need to send a new patch.
======================================================================== http://mondrian.corp.google.com/file/9447213///depot/googleclient/gears/opensource/gears/base/common/permissions_manager.h?a=1 File //depot/googleclient/gears/opensource/gears/base/common/permissions_manager.h (snapshot 1) ------------------------------------ Line 42: bool AcquirePermission(PermissionsDB::PermissionType type); I think that you should add the BrowsingContext argument to this method too. That way, callers who don't use the CustomContent argument can use this method. Currently, your change has obsoleted this method. The BrowsingContext argument should be second in both methods for consistency. ======================================================================== http://mondrian.corp.google.com/file/9447213///depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc?a=1 File //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc (snapshot 1) ------------------------------------ Line 385: EnvPageBrowsingContext()); Tab ------------------------------------ Line 1631: geo_module->EnvPageBrowsingContext())) { Tab ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9447213
