Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9449668
or point your web browser to
http://mondrian/9449668
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 9449668 by jrip...@jripley-gears-trunk on 2008/12/17 17:13:29 *pending*
Workaround badly formed Android compressed HTML.
The compressed HTML files for Android dialogs aren't working,
so for now this uses the uncompressed versions. Left the old
build rule commented next to the modified one.
PRESUBMIT=passed
R=andreip
[email protected]
DELTA=4 (3 added, 0 deleted, 1 changed)
OCL=9449668
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#95 edit
4 delta lines: 3 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9449668 by jrip...@jripley-gears-trunk on 2008/12/17 17:13:29 *pending*
Workaround badly formed Android compressed HTML.
The compressed HTML files for Android dialogs aren't working,
so for now this uses the uncompressed versions. Left the old
build rule commented next to the modified one.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#95 edit
==== //depot/googleclient/gears/opensource/gears/tools/rules.mk#95 -
/usr/local/google/home/jripley/gears-trunk/googleclient/gears/opensource/gears/tools/rules.mk
====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/rules.mk 2008-12-17
17:12:10.000000000 +0000
+++ googleclient/gears/opensource/gears/tools/rules.mk 2008-12-17
17:02:38.000000000 +0000
@@ -1183,7 +1183,10 @@
@echo "Strip $<"
@$(CROSS_PREFIX)strip $@
-$(ANDROID_INSTALLER_OUTDIR)/%.html: $(NPAPI_OUTDIR)/genfiles/%.html.compress
+# TODO(jripley): The compressed html files are not working. Use the
+# uncompressed ones for now.
+#$(ANDROID_INSTALLER_OUTDIR)/%.html: $(NPAPI_OUTDIR)/genfiles/%.html.compress
+$(ANDROID_INSTALLER_OUTDIR)/%.html: $(NPAPI_OUTDIR)/genfiles/%.html
@echo "Copy `basename $...@`"
@mkdir -p $(ANDROID_INSTALLER_OUTDIR)
@cp $< $@
