What do you think of the two TODOs? // TODO(michaeln): Should we be looking at SetProperty's return value? // TODO(michaeln): Should we be looking at SetElement's return value?
if (!foo->SetThingy(..)) return false; On Wed, Dec 17, 2008 at 4:27 PM, Nigel Tao <[email protected]> wrote: > LGTM > >>> Can you add a test case to test/testcases/workerpool_message_body_tests.js? >> >> I'm not sure how to induce this failure mode? > > Ah, yes, this is failure during unmarshal, not during marshal, and the > assumption is that if something can't unmarshal, then it will fail at the > marshalling stage. It's probably not worth the effort to make a special Gears > module that overrides AsMarshaledModule but fails to unmarshal. > > -- > To respond, reply to this email or visit > http://mondrian.corp.google.com/9455628 >
