Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 9475263
or point your web browser to
http://mondrian/9475263
to review the following code:
Change 9475263 by nigel...@nigeltao-srcgears4 on 2008/12/19 12:58:39 *pending*
Remove unused media code.
PRESUBMIT=passed
R=aa
[email protected]
DELTA=3561 (0 added, 3544 deleted, 17 changed)
OCL=9475263
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#223 edit
... //depot/googleclient/gears/opensource/gears/base/common/permissions_db.h#11
edit
... //depot/googleclient/gears/opensource/gears/cctests/test.cc#90 edit
... //depot/googleclient/gears/opensource/gears/cctests/test.h#30 edit
... //depot/googleclient/gears/opensource/gears/factory/factory_impl.cc#21 edit
... //depot/googleclient/gears/opensource/gears/factory/factory_utils.cc#4 edit
... //depot/googleclient/gears/opensource/gears/media/audio.cc#9 delete
... //depot/googleclient/gears/opensource/gears/media/audio.h#3 delete
... //depot/googleclient/gears/opensource/gears/media/audio_recorder.cc#9 delete
... //depot/googleclient/gears/opensource/gears/media/audio_recorder.h#6 delete
...
//depot/googleclient/gears/opensource/gears/media/audio_recorder_constants.h#2
delete
... //depot/googleclient/gears/opensource/gears/media/audio_recorder_test.cc#1
delete
... //depot/googleclient/gears/opensource/gears/media/audio_recorder_test.h#1
delete
... //depot/googleclient/gears/opensource/gears/media/base_audio_recorder.cc#2
delete
... //depot/googleclient/gears/opensource/gears/media/base_audio_recorder.h#1
delete
... //depot/googleclient/gears/opensource/gears/media/media.cc#6 delete
... //depot/googleclient/gears/opensource/gears/media/media.h#6 delete
... //depot/googleclient/gears/opensource/gears/media/media_constants.h#1 delete
... //depot/googleclient/gears/opensource/gears/media/media_data.cc#1 delete
... //depot/googleclient/gears/opensource/gears/media/media_data.h#1 delete
... //depot/googleclient/gears/opensource/gears/media/mock_audio_recorder.cc#1
delete
... //depot/googleclient/gears/opensource/gears/media/mock_audio_recorder.h#1
delete
... //depot/googleclient/gears/opensource/gears/media/pa_audio_recorder.cc#2
delete
... //depot/googleclient/gears/opensource/gears/media/pa_audio_recorder.h#2
delete
... //depot/googleclient/gears/opensource/gears/media/time_ranges.cc#3 delete
... //depot/googleclient/gears/opensource/gears/media/time_ranges.h#3 delete
...
//depot/googleclient/gears/opensource/gears/test/testcases/audio_recorder_tests.js#3
delete
... //depot/googleclient/gears/opensource/gears/test/testcases/audio_tests.js#4
delete
... //depot/googleclient/gears/opensource/gears/test/testcases/config.js#36 edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/data/audio_int16_file1.raw#1
delete
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_audio_recorder_tests.js#1
delete
... //depot/googleclient/gears/opensource/gears/tools/config.mk#94 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#96 edit
3561 delta lines: 0 added, 3544 deleted, 17 changed
Also consider running:
g4 lint -c 9475263
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
