Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9479425
or point your web browser to
http://mondrian/9479425
to review the following code:
Change 9479425 by stevebl...@steveblock-gears3 on 2008/12/19 11:57:26 *pending*
Adds some debug info to testMockDeviceDataProvider.
This test often fails the automated tests on Linux FF but I can't
reproduce on my workstation. Hopefully this will help work out what's failing.
R=andreip
[email protected]
DELTA=12 (4 added, 0 deleted, 8 changed)
OCL=9479425
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#14
edit
12 delta lines: 4 added, 0 deleted, 8 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9479425 by stevebl...@steveblock-gears3 on 2008/12/19 11:57:26 *pending*
Adds some debug info to testMockDeviceDataProvider.
This test often fails the automated tests on Linux FF but I can't
reproduce on my workstation. Hopefully this will help work out what's failing.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#14
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#14
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
====
# action=edit type=text
---
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2008-12-19 11:58:29.000000000 +0000
+++
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2008-12-19 11:13:46.000000000 +0000
@@ -315,8 +315,8 @@
{mac_address: 'good_mac_address'});
geolocation.getCurrentPosition(
successCallback,
- function() {
- assert(false, 'makeSuccessfulRequest failed');
+ function(error) {
+ assert(false, 'makeSuccessfulRequest failed: ' + error.message);
},
{
gearsRequestAddress: true,
@@ -328,8 +328,9 @@
internalTests.configureGeolocationWifiDataProviderForTest(
{mac_address: 'no_location_mac_address'});
geolocation.getCurrentPosition(
- function() {
- assert(false, 'makeUnsuccessfulRequest succeeded');
+ function(position) {
+ assert(false, 'makeUnsuccessfulRequest succeeded: (' +
+ position.latitude + ', ' + position.longitude + ')');
},
noPositionErrorCallback,
{gearsLocationProviderUrls: [mockNetworkLocationProvider]});
@@ -340,8 +341,9 @@
{mac_address: '00-00-00-00-00-00'});
internalTests.configureGeolocationRadioDataProviderForTest({cell_id:
88});
geolocation.getCurrentPosition(
- function() {
- assert(false, 'makeMalformedRequest succeeded');
+ function(position) {
+ assert(false, 'makeMalformedRequest succeeded: (' +
+ position.latitude + ', ' + position.longitude + ')');
},
malformedRequestErrorCallback,
{gearsLocationProviderUrls: [mockNetworkLocationProvider]});
@@ -372,13 +374,15 @@
function noPositionErrorCallback(error) {
assertEqual(error.POSITION_UNAVAILABLE, error.code);
- assert(error.message.search('did not provide a good position fix') > 0);
+ assert(error.message.search('did not provide a good position fix') > 0,
+ 'Unexpected error message');
makeMalformedRequest();
};
function malformedRequestErrorCallback(error) {
assertEqual(error.POSITION_UNAVAILABLE, error.code);
- assert(error.message.search('returned error code 400') > 0);
+ assert(error.message.search('returned error code 400') > 0,
+ 'Unexpected error message');
completeAsync();
};
