========================================================================
http://mondrian.corp.google.com/file/9505817///depot/googleclient/gears/opensource/gears/base/common/thread_locals.cc?a=1
File //depot/googleclient/gears/opensource/gears/base/common/thread_locals.cc 
(snapshot 1)
------------------------------------
Line 33: #define BROWSER_IE 1
Let's just use BROWSER_CHROME below and get rid of this?
------------------------------------
Line 39: #if BROWSER_IE || BROWSER_OPERA
|| BROWSER_CHROME
========================================================================
http://mondrian.corp.google.com/file/9505817///depot/googleclient/gears/opensource/gears/timer/timer.h?a=1
File //depot/googleclient/gears/opensource/gears/timer/timer.h (snapshot 1)
------------------------------------
Line 46: #define OS_ANDROID 1
This is strange, we should ask michaeln/mpcomplete. It seems Chrome now uses the
Android timer implementation. But we're about to change that to use
NPN_ScheduleCallback (or whatever it was called), which may not work on Chrome.
========================================================================
http://mondrian.corp.google.com/file/9505817///depot/googleclient/gears/opensource/gears/timer/timer.h?a=0
File //depot/googleclient/gears/opensource/gears/timer/timer.h
------------------------------------
Line 238: #undef BROWSER_IE
Whoa...
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/9505817

Reply via email to