Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9512774
or point your web browser to
http://mondrian/9512774
to review the following code:
Change 9512774 by stevebl...@steveblock-gears3 on 2008/12/23 12:16:33 *pending*
Updates browser executable path for Opera Mobile.
R=andreip
[email protected],[email protected],[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9512774
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/opera/setup.cc#1 edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9512774
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9512774 by stevebl...@steveblock-gears3 on 2008/12/23 12:16:33 *pending*
Updates browser executable path for Opera Mobile.
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/opera/setup.cc#1 edit
==== //depot/googleclient/gears/opensource/gears/installer/opera/setup.cc#1 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/installer/opera/setup.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/installer/opera/setup.cc
2008-12-23 12:18:23.000000000 +0000
+++ googleclient/gears/opensource/gears/installer/opera/setup.cc
2008-12-23 12:14:25.000000000 +0000
@@ -31,7 +31,7 @@
#include "gears/installer/common/resource.h" // for restart dialog strings
static const char16* kOperaProcessName = L"Opera9.exe";
-static const char16* kOperaLaunchExe = L"\\Program Files\\9.5
Beta\\OperaL.exe";
+static const char16* kOperaLaunchExe = L"\\Program Files\\Opera 9.5
Beta\\OperaL.exe";
static const char16* kGearsSite = L"http://gears.google.com/done.html";;
HINSTANCE module_instance;
