Hello playmobil,
I'd like you to do a code review. Please execute
g4 diff -c 9561013
or point your web browser to
http://mondrian/9561013
to review the following code:
Change 9561013 by z...@zkuznia-corp3 on 2008/12/30 09:43:54 *pending*
Fix shortcut dialog to properly align application information in RTL
locales
R=playmobil
[email protected]
DELTA=3 (2 added, 0 deleted, 1 changed)
OCL=9561013
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#6
edit
3 delta lines: 2 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9561013 by z...@zkuznia-corp3 on 2008/12/30 09:43:54 *pending*
Fix shortcut dialog to properly align application information in RTL
locales
Affected files ...
...
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#6
edit
====
//depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#6
-
c:\src-gears3/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
2008-12-30 09:42:45.000000000 -0800
+++ googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
2008-12-30 09:36:28.000000000 -0800
@@ -37,6 +37,7 @@
m4_include(ui/common/html_dialog.css)
#icon {
margin-right:0.5em;
+ margin-left:0.5em;
}
#content {
@@ -50,6 +51,7 @@
#scroll img {
margin-right:1em;
+ margin-left:1em;
}
#highlightbox {
@@ -66,7 +68,7 @@
border-width:0 1px;
padding:1em;
}
-
+
#shortcut-name {
margin-bottom:2px;
font-weight: bold;
@@ -140,7 +142,7 @@
<table cellpadding="0" cellspacing="0" border="0">
<tr>
<td valign="top"><img id="shortcut-icon" width="32" height="32"
src="blank.gif"></td>
- <td align="left" width="100%" valign="middle">
+ <td width="100%" valign="middle">
<div id="shortcut-name"></div
><div id="shortcut-description"></div>
</td>
