Hello jabdelmalek,
I'd like you to do a code review. Please execute
g4 diff -c 9745692
or point your web browser to
http://mondrian/9745692
to review the following code:
Change 9745692 by mpcompl...@mpcomplete-gears on 2009/01/15 17:03:20 *pending*
Change exported CP_ and NP_ function names for when we statically link
with Chrome.
R=jabdelmalek
[email protected]
DELTA=7 (7 added, 0 deleted, 0 changed)
OCL=9745692
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/chrome/static_lib.h#1 edit
7 delta lines: 7 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 9745692
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9745692 by mpcompl...@mpcomplete-gears on 2009/01/15 17:03:20 *pending*
Change exported CP_ and NP_ function names for when we statically link
with Chrome.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/chrome/static_lib.h#1 edit
==== //depot/googleclient/gears/opensource/gears/base/chrome/static_lib.h#1 -
C:\src\gears/googleclient/gears/opensource/gears/base/chrome/static_lib.h ====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/chrome/static_lib.h
2009-01-15 17:05:46.000000000 -0800
+++ googleclient/gears/opensource/gears/base/chrome/static_lib.h
2009-01-15 17:02:26.000000000 -0800
@@ -29,6 +29,13 @@
#ifndef GEARS_BASE_COMMON_STATIC_LIB_H__
#define GEARS_BASE_COMMON_STATIC_LIB_H__
+// These functions are used by Chrome, so their names must not change.
+#define NP_GetEntryPoints Gears_NP_GetEntryPoints
+#define NP_Initialize Gears_NP_Initialize
+#define NP_Shutdown Gears_NP_Shutdown
+#define CP_Initialize Gears_CP_Initialize
+
+// These functions are used only by Gears.
#define GetV8Context gears_GetV8Context
#define WrapNPObject gears_WrapNPObject
#define NPScriptObjectClass gears_NPScriptObjectClass
