======================================================================== http://mondrian.corp.google.com/file/9464280///depot/googleclient/gears/opensource/gears/base/common/js_runner.h?a=4 File //depot/googleclient/gears/opensource/gears/base/common/js_runner.h (snapshot 4) ------------------------------------ Line 104: virtual void ClearThreadIdentifier(){} Do these methods need to be part of JsRunnerInterface? Could they be part of only the NPAPI implementation of JsRunnerBase? ======================================================================== http://mondrian.corp.google.com/file/9464280///depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/js_runner_np.cc (snapshot 1) ------------------------------------ Line 223: SetThreadIdentifier(); Tabs ------------------------------------ Line 642: // common functionality to both workers and the main thread. I think this comment is incorrect - this a version of JsRunner, right? ------------------------------------ Line 645: OperaJsRunner(NPP instance, void* object) Rather than passing the global object through to this function from OperaWorkerThreadImpl::CreateWorkerFactory, could you add a method to OperaGearsApiInterface to get the global object? That way, we wouldn't need a new version of NewJsRunner? ======================================================================== http://mondrian.corp.google.com/file/9464280///depot/googleclient/gears/opensource/gears/base/common/js_types.h?a=4 File //depot/googleclient/gears/opensource/gears/base/common/js_types.h (snapshot 4) ------------------------------------ Line 548: NPObject *js_object() { return object_; } Is this method used outside of this class? If not, do we need a public method? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9464280
