========================================================================
http://mondrian.corp.google.com/file/9500806///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc?a=7
File
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc
(snapshot 7)
------------------------------------
Line 237: Ref();
On 12:53 pm, noel wrote:
> Could we add a LOG() here to help debug the ref counting, and same at @226 and
> @243.
Done.
------------------------------------
Line 273: cached_meta_data_is_valid_ = false;
On 12:55 pm, noel wrote:
> @273 Member cached_meta_data_ maybe holding memory when this line marks it
> invalid. A cached_meta_data_.Reset()
> call would free that memory. Is there some reason you
> need to hold on to that memory here?
We could do a Reset call here, but my thought was to do all the modifications to
cached_meta_data_ in one place, namely inside GetFileDragAndDropMetaData. It's
probably no biggie either way.
------------------------------------
Line 327: Ref(); // Balanced by an Unref() during HandleEvent(JSEVENT_UNLOAD).
On 1:33 pm, noel wrote:
> You store new-ed DropTargetInterceptor in a scoped_refptr<> in
> drop_target_ie.cc. Why is this Ref() call needed?
Comment added.
------------------------------------
Line 329: RegisterDragDrop(hwnd_, this);
On 1:05 pm, noel wrote:
> These calls might fail right? Should I worry? Did you test the failure
modes?
TODO added.
------------------------------------
Line 344: if (_tcscmp(class_name, L"Internet Explorer_Server")) {
On 2:47 pm, noel wrote:
> _wcscmp, my mistake.
Done.
========================================================================
http://mondrian.corp.google.com/file/9500806///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.h?a=3
File
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.h
(snapshot 3)
------------------------------------
Line 40: // a file drop. In comparison, trying to set event.dropEffect to
'none', via
On 11:19 am, noel wrote:
> s/event.dropEffect/event.dataTransfer.dropEffect/
Done.
========================================================================
--
To respond, reply to this email or visit http://mondrian.corp.google.com/9500806
