Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 9906950
or point your web browser to
http://mondrian/9906950
to review the following code:
Change 9906950 by nigel...@nigeltao-srcwingears8 on 2009/01/29 15:28:12
*pending*
In drag-and-drop, fix a NULL pointer dereference on Vista/IE7 (as
opposed
to XP/IE6), where IHTMLWindow2::get_event(&result) can return S_OK but
the result is NULL.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=2 (2 added, 0 deleted, 0 changed)
OCL=9906950
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc#6
edit
2 delta lines: 2 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 9906950
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9906950 by nigel...@nigeltao-srcwingears8 on 2009/01/29 15:28:12
*pending*
In drag-and-drop, fix a NULL pointer dereference on Vista/IE7 (as
opposed
to XP/IE6), where IHTMLWindow2::get_event(&result) can return S_OK but
the result is NULL.
OCL=9906950
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc#6
edit
====
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc#6
-
c:\devel\srcwingears8/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc
2009-01-29 15:30:46.000000000 +1100
+++ googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc
2009-01-29 15:24:15.000000000 +1100
@@ -160,7 +160,9 @@
CComBSTR type;
if (FAILED(ActiveXUtils::GetHtmlWindow2(
module_environment->iunknown_site_, &window)) ||
+ (window == NULL) ||
FAILED(window->get_event(&window_event)) ||
+ (window_event == NULL) ||
FAILED(window_event->get_type(&type))) {
// If we get here, then there is no window.event, so we are not in
// the browser's event dispatch.
