======================================================================== http://mondrian.corp.google.com/file/9908094///depot/googleclient/gears/opensource/gears/base/common/base_class.cc?a=1 File //depot/googleclient/gears/opensource/gears/base/common/base_class.cc (snapshot 1) ------------------------------------ Line 66: drop_target_interceptor_.reset(DropTargetInterceptor::Intercept(this)); On 3:55 pm, noel wrote: > For the #elif, BROWSER_IE && !defined(OS_WINCE)? What about OFFICAL_BUILD? > > Workers use this class too, so restrict the reset() call to the main (browser) > thread only.
Done. ======================================================================== http://mondrian.corp.google.com/file/9908094///depot/googleclient/gears/opensource/gears/base/common/base_class.h?a=1 File //depot/googleclient/gears/opensource/gears/base/common/base_class.h (snapshot 1) ------------------------------------ Line 97: #if BROWSER_IE On 3:55 pm, noel wrote: > #if, BROWSER_IE && !defined(OS_WINCE)? What about OFFICAL_BUILD? Done. ======================================================================== http://mondrian.corp.google.com/file/9908094///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc (snapshot 1) ------------------------------------ Line 260: } On 3:53 pm, noel wrote: > What if the user is dragging over the browser, and some javascript event handler > sets dropEffect to "move", and then prevents the default action and cancels > bubbling? > > The code here will override their cursor with "copy"; I don't see why we'd want > to do that. Done. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9908094
