Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9985692
or point your web browser to
http://mondrian/9985692
to review the following code:
Change 9985692 by stevebl...@steveblock-gears2 on 2009/02/03 23:23:45 *pending*
Properly close <code> tag in gears_faq.html.
Note that this has already been fixed in the corresponding codesite ezt
file in CL 9985673.
R=andreip
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9985692
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#12 edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9985692 by stevebl...@steveblock-gears2 on 2009/02/03 23:23:45 *pending*
Properly close <code> tag in gears_faq.html.
Note that this has already been fixed in the corresponding codesite ezt
file in CL 9985673.
Affected files ...
... //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#12 edit
==== //depot/googleclient/gears/opensource/gears/sdk/gears_faq.html#12 -
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/sdk/gears_faq.html ====
# action=edit type=text
--- googleclient/gears/opensource/gears/sdk/gears_faq.html 2008-12-17
18:29:46.000000000 +0000
+++ googleclient/gears/opensource/gears/sdk/gears_faq.html 2009-02-03
23:26:14.000000000 +0000
@@ -1995,7 +1995,7 @@
</p>
<p>
- First, make sure you always close <em>both</em> your database
<em>and</em> your <code>ResultSets</code>. Both database connections and
ResultSets are handles to OS-level resources that should be closed when
finished. The best way to do this is to have a <code>finally<code> block that
will get run whether an exception occurs or not:
+ First, make sure you always close <em>both</em> your database
<em>and</em> your <code>ResultSets</code>. Both database connections and
ResultSets are handles to OS-level resources that should be closed when
finished. The best way to do this is to have a <code>finally</code> block that
will get run whether an exception occurs or not:
</p>
<pre class="prettyprint">
