Hello nicolasroard,
I'd like you to do a code review. Please execute
g4 diff -c 10016983
or point your web browser to
http://mondrian/10016983
to review the following code:
Change 10016983 by andr...@andreip-gearsjscore on 2009/02/05 16:45:26 *pending*
Fix problem where unitialized static variable triggers an
assert in Android debug builds.
PRESUBMIT=passed
BUG=1628455
R=nicolasroard
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10016983
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/android/java_jni.cc#1 edit
1 delta lines: 0 added, 0 deleted, 1 changed
The issue description(s) relevant to this code can be found at:
http://b/issue?id=1628455
Also consider running:
g4 lint -c 10016983
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10016983 by andr...@andreip-gearsjscore on 2009/02/05 16:45:26 *pending*
Fix problem where unitialized static variable triggers an
assert in Android debug builds.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/android/java_jni.cc#1 edit
==== //depot/googleclient/gears/opensource/gears/base/android/java_jni.cc#1 -
/home/andreip/GearsJSCore/googleclient/gears/opensource/gears/base/android/java_jni.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/android/java_jni.cc
2009-02-05 16:46:05.000000000 +0000
+++ googleclient/gears/opensource/gears/base/android/java_jni.cc
2009-02-05 14:42:25.000000000 +0000
@@ -34,7 +34,7 @@
// JniRegisterMainThread(), and by JniAttachCurrentThread() on others.
static const ThreadLocalValue<JNIEnv *> s_jni_env_tls;
// The ID of the main thread, initialized by JniRegisterMainThread().
-static pthread_t s_main_thread_id;
+static pthread_t s_main_thread_id = 0;
// Pointer to the browser's main thread queuing function. This is an
// NPAPI call which we'll store here separately to the NPN structure
// as this is a special case that is available on all
