On Tue, 03 Feb 2009 12:17:01 +0100, Steve Block <[email protected]> wrote:
> Hello andreip, > > I'd like you to do a code review. Please execute > g4 diff -c 9974992 > > or point your web browser to > http://mondrian/9974992 > > to review the following code: > > Change 9974992 by stevebl...@steveblock-gears1 on 2009/02/03 11:09:02 > *pending* > > Temporarily disables testRemoveCrossThread() for Opera Mobile. > This test makes assumptions about the message queues in Gears which are > > not true for Opera Mobile. > > Deepak, it looks like the reason that this test fails on Opera > Mobile is that it makes assumptions about the way > messages are delivered between threads in Gears, which are not > true for Opera Mobile. Take a look at the patch and > let me know if that sounds like a reasonable diagnosis. If so, > we'll disable the test for now and revisit the issue later. Sounds good to me. > > Note that to make this change, I've modified the build info > string for Gears for Opera from 'npapi' to 'opera'. > The use of 'npapi' was for leagcy reasons and I think this makes > sense in general. Let me know if that's OK with you. This is OK with me. I suppose you have already made the change to factory_utils.cc? I'll update from the tip-of-tree. Deepak. > > R=andreip > [email protected],[email protected],[email protected] > DELTA=20 (20 added, 0 deleted, 0 changed) > OCL=9974992 > > Affected files ... > > ... > //depot/googleclient/gears/opensource/gears/test/testcases/database_tests.js#8 > > edit > ... //depot/googleclient/gears/opensource/gears/test/tester/assert.js#13 > edit > > 20 delta lines: 20 added, 0 deleted, 0 changed > > If you can't do the review, please let me know as soon as possible. > During > your review, please ensure that all new code has corresponding unit > tests and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or > suggestions? > Mail [email protected]. -- Deepak Prabhakara Developer, Windows Mobile Opera Software +47-96831977
