======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/Makefile?a=1 File //depot/googleclient/gears/opensource/gears/Makefile (snapshot 1) ------------------------------------ Line 1267: On 4:14 pm, nigeltao wrote:
Done. ------------------------------------ Line 1271: On 4:14 pm, nigeltao wrote: Done. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/Makefile?a=0 File //depot/googleclient/gears/opensource/gears/Makefile ------------------------------------ Line 2065: IEMOBILE_CPPSRCS += \ On 4:14 pm, nigeltao wrote: Done. ------------------------------------ Line 2096: OPERA_CPPSRCS += \ On 4:14 pm, nigeltao wrote: Done. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/desktop/desktop.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/desktop.cc (snapshot 1) ------------------------------------ Line 63: #else On 4:26 pm, nigeltao wrote: Done. ------------------------------------ Line 287: // On platforms other than Windows desktop, the HTML dialog always returns On 4:27 pm, nigeltao wrote: a whitespace diff maybe, left and right are unchanged. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/desktop/drop_target_base.h?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_base.h (snapshot 1) ------------------------------------ Line 36: #elif BROWSER_NPAPI && WIN32 On 4:19 pm, nigeltao wrote: done, removed the comment, and the TODO(you) above too. Note: BROWSER_NPAPI make the code look active in VS2005, whereas, BROWSER_CHROME does not -- some issue with VS project scripts. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.cc?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.cc (snapshot 1) ------------------------------------ Line 1: // Copyright 2008, Google Inc. On 5:15 pm, nigeltao wrote: Done. ------------------------------------ Line 44: #include "gears/desktop/tracewin.h" sorry, removed. ------------------------------------ Line 50: // dicey; it needs to be per-NPP-instance state. On 5:39 pm, nigeltao wrote: My comments apply to Chrome. I added something about out of sequence events. ------------------------------------ Line 55: static std::set<std::string16> m_mime_set; On 4:32 pm, nigeltao wrote: Done. ------------------------------------ Line 67: class EventListener : public PluginBase { moot points I think, we can move on. ------------------------------------ Line 85: data_ = data, callback_ = callback; On 5:13 pm, nigeltao wrote: Done. ------------------------------------ Line 129: #define ELEMENT_EVENT_DRAGENTER 1 These will be defined in the CPAPI from Chrome, just wanted to match those, it'll be an enum there. ------------------------------------ Line 141: target->Ref(); // Ref() the drop target and return it. removed. ------------------------------------ Line 150: JsDomElement &element, JsObject *options, std::string16 *error) yeah removed. ------------------------------------ Line 158: listener_ = NULL; ok done, except that accept_, dragging_ are lazily inited. ------------------------------------ Line 315: NPN_GetValue(npp_, static_cast<NPNVariable>(7000), &event_); yeah this is why in dicussion with Matt who is advising me on the Chrome side, we decided to use CPAPI and make it all explicit and gears-only, and avoid having to update npapi include files/version to define the magic numbers. ------------------------------------ Line 374: private: On 4:35 pm, nigeltao wrote: Done. ------------------------------------ Line 380: private: On 4:36 pm, nigeltao wrote: Done. ------------------------------------ Line 382: int32 identity_; On 4:35 pm, nigeltao wrote: Far enough. I didn't explain that the NPN_GetData() calls write all this data on success. The CPAPI rewrite is a TODO to be more explicit the data Chrome returns. ------------------------------------ Line 383: int32 event_id_; On 5:08 pm, nigeltao wrote: see above. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.h?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.h (snapshot 1) ------------------------------------ Line 1: // Copyright 2008, Google Inc. On 4:38 pm, nigeltao wrote: Done. ------------------------------------ Line 30: // The Drag-and-Drop API has not been finalized for official builds. On 4:22 pm, nigeltao wrote: Done. ------------------------------------ Line 32: #if defined(BROWSER_NPAPI) && defined(WIN32) On 4:23 pm, nigeltao wrote: Done. ======================================================================== http://mondrian.corp.google.com/file/10012347///depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h?a=1 File //depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h (snapshot 1) ------------------------------------ Line 43: #elif BROWSER_NPAPI && WIN32 // Chrome On 4:19 pm, nigeltao wrote: Done. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10012347
